search

asyncapi / cli

CLI to work with your AsyncAPI files. You can validate them and in the future use a generator and even bootstrap a new file. Contributions are welcomed!
https://www.asyncapi.com/tools/cli
Apache License 2.0
188 stars 164 forks source link

chore: migrate github-action to cli #1487

Closed akshatnema closed 1 month ago

akshatnema commented 4 months ago

Description

PR to add the github action for cli from https://github.com/asyncapi/github-action-for-cli.

Related issue(s) https://github.com/asyncapi/github-action-for-cli/issues/396

aeworxet commented 4 months ago

@asyncapi/bounty_team

Shurtu-gal commented 2 months ago

/u

Shurtu-gal commented 2 months ago

@akshatnema any blockers being faced by you?

akshatnema commented 2 months ago

There is no update as I'm researching around the fact on how to manage GitHub Action for CLI.

@Shurtu-gal and @derberg proposals require different configurations, which in fact means we need to have the same package.json for both CLI and it's respective GitHub action.

I'm currently looking at how to use only one configuration and one package.json.

Although the matter looks simple, it will take time to try different approaches, so if I don't achieve a break-through in the nearest couple of days, I'll ask for the Timeline Extension.

derberg commented 2 months ago

but the GH action do not need package.json as it is bash and docker based only. So no need for monorepo afaik - I think we talked about it

akshatnema commented 2 months ago

@derberg @Shurtu-gal ok so should we do it in a manner that we completely remove the package.json from github action? Since, there is no need of a separate package.json, our whole github action depends on the working of entrypoint.sh and the versioning for github action scripts can be added to existing package.json of cli, right?

Shurtu-gal commented 2 months ago

@derberg @Shurtu-gal ok so should we do it in a manner that we completely remove the package.json from github action? Since, there is no need of a separate package.json, our whole github action depends on the working of entrypoint.sh and the versioning for github action scripts can be added to existing package.json of cli, right?

That's correct. If I remember correctly the package.json was there just to support the workflows already present.

Shurtu-gal commented 1 month ago

@akshatnema sonarcloud is complaining about the Dockerfile building on a image with root as the default user. Maybe the user being added could be used for further steps through

USER myuser

I may have missed out on this during migrating to bash.

Shurtu-gal commented 1 month ago

/u

Shurtu-gal commented 1 month ago

@aeworxet this issue is pretty complicated as some things related to containerizing part is still not working and we still have to do the automation of version locking and bumping. @akshatnema is also pretty new to the CLI repo so is it possible to reclassify this bounty as advanced and extend it for 1-2 weeks.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud