asyncapi / modelina

A library for generating typed models based on inputs such as AsyncAPI, OpenAPI, and JSON Schema documents with high customization
https://modelina.org
Apache License 2.0
322 stars 184 forks source link

fix!: when allowInheritance is true, java now renders setters in interfaces for enums if const is not set by the classes that implements it #2096

Closed kennethaasan closed 2 months ago

kennethaasan commented 2 months ago

Description

2068 introduced some breaking changes for the Java code that Java users didn't like. They want setters when they can exist, and this fixes that.

In Java, when a class implements an interface, it must implement all the methods of that interface. Therefore, if allowInheritance is set to true, Modelina will no longer render the setter for enums in interfaces if the property exists in the implemented by class with a constant value.

Related Issue

Checklist

Additional Notes

Fixes #2068

netlify[bot] commented 2 months ago

Deploy Preview for modelina canceled.

Name Link
Latest commit 2ab0861b2a33ce5e5535d0736004a588907e914c
Latest deploy log https://app.netlify.com/sites/modelina/deploys/66d9633e17bc7c0008edd77c
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

asyncapi-bot commented 2 months ago

:tada: This PR is included in version 4.0.0-next.60 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

asyncapi-bot commented 2 months ago

:tada: This issue has been resolved in version 4.0.0-next.61 :tada:

The release is available on:

Your semantic-release bot :package::rocket: