asyncapi / website

AsyncAPI specification website
https://www.asyncapi.com
Apache License 2.0
445 stars 594 forks source link

[BUG] Newsletter page does not have correct button labels #3236

Open JeelRajodiya opened 1 week ago

JeelRajodiya commented 1 week ago

Describe the bug.

The labels for the buttons and input fields simply have the i18n placeholders instead of the actual labels

image

Expected behavior

These are the expected labels

image

How to Reproduce

  1. Go to https://www.asyncapi.com/newsletter
  2. You will notice the improper labels

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

No, someone else can work on it

jayp5545 commented 1 week ago

I can work on it!

sambhavgupta0705 commented 1 week ago

How do we access newsletter page?

JeelRajodiya commented 1 week ago

How do we access newsletter page?

I am not sure either, I was just going through the codebase and found that we have pages/newsletter.tsx file. Which means the page exists at https://www.asyncapi.com/newsletter

image

sambhavgupta0705 commented 1 week ago

@akshatnema do we need this url as we only have newsletter at the home page which is working fine

hkv24 commented 1 week ago

@sambhavgupta0705 look at 'components/NewsletterSubscribe.tsx'

prashantrai-30 commented 1 week ago

Hey,@JeelRajodiya can you assign this to me.

JeelRajodiya commented 1 week ago

Found it. Here is how you can access the /newsletter page

1. Go to the footer of the website.

2. Click on About

image

3. Now on the about page. you will find a link to the newsletter

image

That's not it. The newsletter page is also linked from multiple blogs

JeelRajodiya commented 1 week ago

Hey,@JeelRajodiya can you assign this to me.

Issues are not assigned on the website repo (AFAIK). If the issue is valid, you can start working on it and a create PR.