Closed SahilDahekar closed 2 weeks ago
The pull request introduces a new React component, CommunityEvents
, which manages and displays community events. It replaces state management in the EventIndex
component, delegating event handling to CommunityEvents
. Additionally, static properties are added to several components using makeStaticProps
, enhancing data-fetching capabilities. Modifications also include refactoring social media icons in the tsc
page to remove state management. Lastly, a fallback mechanism is implemented in the getI18nProps
function to ensure a default locale.
File | Change Summary |
---|---|
components/CommunityEvents.tsx | Added CommunityEvents component; manages events and renders them conditionally. |
pages/community/events/index.tsx | Updated EventIndex to use CommunityEvents ; removed state management and event filtering. |
pages/community/index.tsx | Added getStaticProps for static site generation. |
pages/community/tsc.tsx | Added getStaticProps ; refactored social media icons to remove hover state management. |
utils/getStatic.ts | Modified getI18nProps to include a fallback for the locale variable. |
Objective | Addressed | Explanation |
---|---|---|
Button should be named differently (issue #3381) | ❌ | No changes to button names were made in this PR. |
AlgoliaSearch.tsx
component, potentially related to event management.MenuBlocks
component, which may relate to the layout of CommunityEvents
.CommunityEvents
.CommunityEvents
.ready-to-merge
, bounty
🐰 In the community, we gather and share,
Events to enjoy, with friends everywhere.
With filters and lists, we make it just right,
Join us in fun, from morning till night!
Let's hop to the beat, with joy and delight! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | d5c9d59c6de5f6df0008cb164c3f8dcd47350ba3 |
Latest deploy log | https://app.netlify.com/sites/asyncapi-website/deploys/67339905caf0bf00081565f6 |
Deploy Preview | https://deploy-preview-3384--asyncapi-website.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
⚡️ Lighthouse report for the changes in this PR: | Category | Score |
---|---|---|
🔴 Performance | 46 | |
🟢 Accessibility | 98 | |
🟢 Best practices | 92 | |
🟢 SEO | 100 | |
🔴 PWA | 33 |
Lighthouse ran on https://deploy-preview-3384--asyncapi-website.netlify.app/
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.77%. Comparing base (
6f15381
) to head (d5c9d59
). Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Potential duplicate of #3308
Should this PR be closed then since this is a duplicate ?? @bandantonio
@SahilDahekar I think yes. You can always compare the changes in both PRs and decide for yourself. But since the issue has already been closed, the linked PR can also be closed. If you find that the original PR lacks some info or can be improved, feel free to contribute to that PR directly but please try to avoid the situation, that was mentioned in that PR
I think PR #3308 is relevant to this issue and is still under review. You should avoid working on the issues which already have a PR open.
Thanks @bandantonio for clarification . I am closing this PR and will directly contribute to the #3308 .
Description
NewsletterSubscribe
component rendering issue on/community/tsc
,/community/events
,/community
page by addinggetStaticProps()
function./community/events
page extractedAll Events
section into new componentCommunityEvents
to be able to usegetStaticProps()
function.useState
hook use for icon hover functionality on/community/tsc
page.getI18nProps()
function in thegetStatic.ts
by adding default locale asen
.Related issue(s)
Fixes #3381
Summary by CodeRabbit
New Features
CommunityEvents
component for displaying and filtering community events.Bug Fixes
Refactor