asyncapi / website

AsyncAPI specification website
https://www.asyncapi.com
Apache License 2.0
526 stars 668 forks source link

fix: rendering issue with few components using next-i18n on community pages #3384

Closed SahilDahekar closed 2 weeks ago

SahilDahekar commented 2 weeks ago

Description

Related issue(s)

Fixes #3381

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request introduces a new React component, CommunityEvents, which manages and displays community events. It replaces state management in the EventIndex component, delegating event handling to CommunityEvents. Additionally, static properties are added to several components using makeStaticProps, enhancing data-fetching capabilities. Modifications also include refactoring social media icons in the tsc page to remove state management. Lastly, a fallback mechanism is implemented in the getI18nProps function to ensure a default locale.

Changes

File Change Summary
components/CommunityEvents.tsx Added CommunityEvents component; manages events and renders them conditionally.
pages/community/events/index.tsx Updated EventIndex to use CommunityEvents; removed state management and event filtering.
pages/community/index.tsx Added getStaticProps for static site generation.
pages/community/tsc.tsx Added getStaticProps; refactored social media icons to remove hover state management.
utils/getStatic.ts Modified getI18nProps to include a fallback for the locale variable.

Assessment against linked issues

Objective Addressed Explanation
Button should be named differently (issue #3381) No changes to button names were made in this PR.

Possibly related PRs

Suggested labels

ready-to-merge, bounty

Suggested reviewers

🐰 In the community, we gather and share,
Events to enjoy, with friends everywhere.
With filters and lists, we make it just right,
Join us in fun, from morning till night!
Let's hop to the beat, with joy and delight! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
netlify[bot] commented 2 weeks ago

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
Latest commit d5c9d59c6de5f6df0008cb164c3f8dcd47350ba3
Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/67339905caf0bf00081565f6
Deploy Preview https://deploy-preview-3384--asyncapi-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

asyncapi-bot commented 2 weeks ago
⚡️ Lighthouse report for the changes in this PR: Category Score
🔴 Performance 46
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3384--asyncapi-website.netlify.app/

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.77%. Comparing base (6f15381) to head (d5c9d59). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3384 +/- ## ======================================= Coverage 67.77% 67.77% ======================================= Files 21 21 Lines 664 664 ======================================= Hits 450 450 Misses 214 214 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bandantonio commented 2 weeks ago

Potential duplicate of #3308

SahilDahekar commented 2 weeks ago

Should this PR be closed then since this is a duplicate ?? @bandantonio

bandantonio commented 2 weeks ago

@SahilDahekar I think yes. You can always compare the changes in both PRs and decide for yourself. But since the issue has already been closed, the linked PR can also be closed. If you find that the original PR lacks some info or can be improved, feel free to contribute to that PR directly but please try to avoid the situation, that was mentioned in that PR

I think PR #3308 is relevant to this issue and is still under review. You should avoid working on the issues which already have a PR open.

SahilDahekar commented 2 weeks ago

Thanks @bandantonio for clarification . I am closing this PR and will directly contribute to the #3308 .