asynkron / protoactor-kotlin

Ultra-fast distributed cross-platform actor framework
http://proto.actor
Apache License 2.0
221 stars 25 forks source link

Endpoint termination and keep alives #32

Closed james-cobb closed 6 years ago

james-cobb commented 6 years ago

Use StreamObserver (like Go implementation) to detect failure of gRPC endpoint. And add ability to alter gRPC settings eg keep alive to speed up detection of failure. See issue #27

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b6cae1f). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   28.99%           
  Complexity        ?      199           
=========================================
  Files             ?       51           
  Lines             ?     1776           
  Branches          ?      296           
=========================================
  Hits              ?      515           
  Misses            ?     1146           
  Partials          ?      115

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6cae1f...c50894e. Read the comment docs.

orjan commented 6 years ago

@james-cobb great work, would you mind incorporating SLF4J in separate pull request, so that we can land that one first? https://github.com/AsynkronIT/protoactor-kotlin/issues/34

james-cobb commented 6 years ago

Ahh my bad, had forgotten there was open PR and shouldn't have made that additional slf4j commit on this branch. Have reverted now.

orjan commented 6 years ago

No worries! Bringing slf4j is a great idea!

On Sun, Feb 4, 2018 at 2:04 PM, james-cobb notifications@github.com wrote:

Ahh my bad, had forgotten there was open PR and shouldn't have made that additional slf4j commit on this branch. Have reverted now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AsynkronIT/protoactor-kotlin/pull/32#issuecomment-362905337, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHkgNcFbVNUcV57fbnNTAPksv1pBwYpks5tRar0gaJpZM4RkMFR .

-- Örjan Sjöholm 0727 - 130037

rogeralsing commented 6 years ago

@james-cobb there are conflicts now

james-cobb commented 6 years ago

Bad merge. Further commit to follow

james-cobb commented 6 years ago

When running test suite locally against this commit it passes sometimes, but intermittently it fails. Hard to reproduce. Needs further investigation.

rogeralsing commented 6 years ago

cc @james-cobb is this one still relevant? I merged your entire dev branch in. so any local fixes you have is now included here

james-cobb commented 6 years ago

Conflict is mostly whitespace, but there is one import difference now. The PR is probably no longer relevant - but I'll get my branches all in sync and look at the diff to make sure nothing has been missed.

james-cobb commented 6 years ago

@rogeralsing I merged in master resolving conflicts (whitespace and one unused import) and the branch now shows no difference to master, so the dev merge covers everything, and this PR is redundant.