search

at-gmbh / personio-py

a lightweight Personio API client
https://at-gmbh.github.io/personio-py
Apache License 2.0
26 stars 17 forks source link

Place authentication in importable file for use with test cases placed in multiple files #11

Closed philipflohr closed 3 years ago

philipflohr commented 3 years ago

This splits the login part from the rest of the raw api tests. While there is no real use of this change right now, in the future this can be used to import the authentication information from multiple test locations

codecov-io commented 3 years ago

Codecov Report

Merging #11 (a7699c6) into master (2bb8a03) will decrease coverage by 0.15%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   84.49%   84.34%   -0.16%     
==========================================
  Files           6        6              
  Lines         729      728       -1     
==========================================
- Hits          616      614       -2     
- Misses        113      114       +1
Impacted Files Coverage Δ
src/personio_py/client.py 78.32% <0.00%> (-0.85%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2bb8a03...a7699c6. Read the comment docs.

philipflohr commented 3 years ago

Hi @klamann all your comments have been addressed. If you don't see other issues this should be ready to be merged.

klamann commented 3 years ago

looks fine for me now!