search

atampy25 / glacierkit

An integrated modding tool for the HITMAN World of Assassination trilogy.
GNU Lesser General Public License v3.0
9 stars 2 forks source link

Linux support #3

Closed dafitius closed 2 months ago

dafitius commented 2 months ago

Linux moment 🥳

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes introduce a new GitHub Action for automating version updates across multiple configuration files, restructure CI/CD workflows to support multi-platform builds, and enhance resource management in the Tauri application through improved file handling and modularisation. Additionally, modifications to game detection and file handling ensure better cross-platform compatibility. The updates focus on improving automation, compatibility, and resource management.

Changes

Files Change Summary
.github/actions/update-versions/action.yml Introduced a new GitHub Action for updating version numbers in package.json, Cargo.toml, and tauri.conf.json.
.github/workflows/build.yml, .github/workflows/release.yml Restructured workflows to support multi-platform builds using a matrix strategy; updated actions to newer versions.
src-tauri/Cargo.toml Added a new dependency home and renamed target configuration from [target."cfg(linux)".dependencies] to [target."cfg(unix)".dependencies].
src-tauri/src/game_detection.rs, src-tauri/src/general.rs, src-tauri/src/show_in_folder.rs Refactored game detection logic, improved file path handling for cross-platform compatibility, and streamlined control flow in folder display functions.
src-tauri/tauri.conf.json Modified beforeBuildCommand to only execute yarn build, removing the batch file execution; updated assetScope and externalBin configurations.
updates.json Added a newline character at the end of the file for formatting purposes.
src-tauri/src/event_handling/resource_overview.rs, src-tauri/src/main.rs Replaced AsyncFileDialog with FileDialogBuilder for file dialog operations, simplifying file handling.
src-tauri/src/game_detection.rs Introduced a nested detection module for better organisation of platform-specific game detection logic.
src-tauri/src/general.rs Enhanced handling of file paths for cross-platform compatibility, particularly addressing case sensitivity on Linux.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
dafitius commented 2 months ago

The vgmstream-cli sidecar binary does not have permissions to execute 1: VGMStream command failed\n 2: Couldn't run command\n 3: Permission denied (os error 13)" }) This should be fixed before merging

dafitius commented 2 months ago

I fixed the permissions thing. It now uses vgmstream-cli as expected. The issue now is that the wavplayer element is not picking up on the wav file inside the temp folder.