search

ataylorme / eslint-annotate-action

A GitHub action that takes ESLint results from a JSON file and adds them as annotated pull request comments
MIT License
88 stars 32 forks source link

update to using Node.js 20 #78

Closed landsman closed 3 months ago

landsman commented 3 months ago

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, ataylorme/eslint-annotate-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

closing: https://github.com/ataylorme/eslint-annotate-action/issues/73

landsman commented 3 months ago

@ataylorme Do you think that automated test in PR good enough? Is there a way how can I test it from this PR in my workflow to be sure that's working properly?

Anyway I recommend performing a major version update to prevent potential issues.

ataylorme commented 3 months ago

@landsman there is already a major version upgrade in progress. Please check out the v3-beta branch. If you can test and provide feedback that would be great

https://github.com/ataylorme/eslint-annotate-action/tree/v3-beta

landsman commented 3 months ago

@ataylorme I see. I did not notice. Can you please create a draft PR to make it visible for others? 🙏

landsman commented 3 months ago

btw I would recommend to add this to: ./.github folder:

# To get started with Dependabot version updates, you'll need to specify which
# package ecosystems to update and where the package manifests are located.
# Please see the documentation for all configuration options:
# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates

version: 2
updates:
  - package-ecosystem: "github-actions"
    directory: "/"
    schedule:
      interval: "daily"

  - package-ecosystem: "npm"
    directory: "/"
    schedule:
      interval: "weekly"
ataylorme commented 3 months ago

@landsman I won’t make a draft PR since it is a major version update with breaking changes.

Once enough testing has been done (I hope you can help test) I’ll remove the -beta tag on the branch and Dependabot should make PRs on repos using this action to go from v2 to v3

mblumenstingl-n11 commented 3 months ago

@ataylorme I created a branch for one of my projects and updated it to use v3-beta. I can confirm that everything works just like it does with v2.2.0:

If there's a better place to give feedback for v3 then please let me know.

Thank you for your work on this useful action! I'm looking forward to seeing v3 released.