search

athensresearch / athens

Athens is no longer maintainted. Athens was an open-source, collaborative knowledge graph, backed by YC W21
https://athensresearch.github.io/athens
Other
6.31k stars 399 forks source link

Don't default daily-notes #1900

Open RussellBloxwich opened 2 years ago

RussellBloxwich commented 2 years ago

Hi All,

I'm aware it would be a relatively substantial change for a few places to make daily-notes the optional default, but not everyone wants to use Athens for daily notes.

For example, I use Athens for my D&D world building and session notes. I also use it (although to limited success) for API and code documentation.

For the time being, I'm building my own binaries without the daily-notes feature by replacing it in defn match-page in cljs/athens/views/pages/core.cljs, but it is far from an ideal solution.

I will look further into adding this functionality, but closure is a little out of my wheelhouse.

Thanks!

ww-daniel-mora commented 2 years ago

Hey @RussellBloxwich amazingly I'm also using Athens for D&D note taking (it's amazing) and would like to turn off automatic daily notes. Perhaps we could collaborate on a PR? I am also new to Clojure. I think we could copy most of the "out-out of reporting" code from the settings page to make a new setting for daily notes and then read the setting in match-page. I started on this over the weekend by just trying to get a new toggle to appear on the page.

ww-daniel-mora commented 2 years ago

High level I think we could copy a lot of this code to introduce a new setting

https://github.com/athensresearch/athens/blob/b5f2c1f74256e898bd2c3f398bb59df41f98b3c7/src/cljs/athens/views/pages/settings.cljs#L252

Store the value in localStorage like monitoring https://github.com/athensresearch/athens/blob/b5f2c1f74256e898bd2c3f398bb59df41f98b3c7/src/cljs/athens/views/pages/settings.cljs#L91 . Then read from localStorage in match-page

hoopahmadness commented 2 years ago

I would love the default page to be the map and having a setting to change it to that (or the Recent Notes) would be great. However, I would be content to just have daily notes not be saved unless I actually add content to the note. I hate having to go through my notes and delete the empty ones. I'm about to create a new issue to that effect but I figured I would mention it here in case you two saw that as a quicker short-term goal for your needs.