atk4 / ui

Robust and easy to use PHP Framework for Web Apps
https://atk4-ui.readthedocs.io
MIT License
443 stars 106 forks source link

Make use of table `scrolling` of FUI 2.9 #1988

Open mkrecek234 opened 1 year ago

mkrecek234 commented 1 year ago

FUI 2.9 offers table scrolling as described in https://fomantic-ui.com/collections/table.html#scrolling Eventually this can help to improve addJsPaginatorInContainer as the current implementation has some issues (e.g. does not support added total line, or added decorators etc.), so we could re-use FUI as much as possible.

mvorisek commented 1 year ago

When non JS paginator is used, no scrolling should be probably present.

What is the improved objective here?

mkrecek234 commented 1 year ago

This is just an idea to make use of FUI scrolling class, instead of Atk4 proprietary HTML rendering in scrolling plugin. This eventually might improve FUI compatibility for scrolling feature as it is natively supported in FUI 2.9.

mvorisek commented 1 year ago

We use plugin to load data dynamically, FUI cannot do that. How can the scrolling help?

mvorisek commented 1 year ago

Is this FR related with infinite/JS scrolling only?

instead of Atk4 proprietary HTML ... as it is natively supported in FUI 2.9

Please provide concrete screenshots of design/behaviour now and after this FR you expect.

mvorisek commented 1 year ago

I would like to have the tables resizeable like textarea - https://stackoverflow.com/questions/11163981/div-resizable-like-text-area

lubber-de commented 1 year ago

I would like to have the tables resizeable like textarea - stackoverflow.com/questions/11163981/div-resizable-like-text-area

Like that? 😉 https://github.com/fomantic/Fomantic-UI/pull/2748

mvorisek commented 1 year ago

related with https://github.com/fomantic/Fomantic-UI/issues/2785

https://github.com/atk4/ui/blob/d40d04710b2854c26e3dfc509d3f4358b0f00b4f/js/src/plugins/scroll.plugin.js#L63-L81

should not be needed anymore then, demo demos/interactive/scroll-grid-container.php, would also probably fix https://github.com/atk4/ui/issues/646