Closed congwang09 closed 3 weeks ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
sdx_controller/init.py | 1 | 2 | 50.0% | ||
sdx_controller/handlers/connection_handler.py | 0 | 1 | 0.0% | ||
<!-- | Total: | 1 | 3 | 33.33% | --> |
Totals | |
---|---|
Change from base Build 10473608051: | 0.0% |
Covered Lines: | 1038 |
Relevant Lines: | 1858 |
It is time to drop Python 3.8 from the test matrix. It is old and unsupported and we do not need to maintain compatibility with it anyway.
The test failure is because we're trying to use the latest pytest version, which pip can't install:
ERROR: Cannot install sdx-controller and sdx-controller[test]==0.1.dev1+gc8c568b because these package versions have conflicting dependencies.
The conflict is caused by:
sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
pytest 8.3.2 depends on pluggy<2 and >=1.5
sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
pytest 8.3.1 depends on pluggy<2 and >=1.5
sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
pytest 8.3.0 depends on pluggy<2 and >=1.5
sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
pytest 8.2.2 depends on pluggy<2.0 and >=1.5
sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
pytest 8.2.1 depends on pluggy<2.0 and >=1.5
sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
pytest 8.2.0 depends on pluggy<2.0 and >=1.5
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
I don't think we care to resolve this conflict. Instead, we can just drop Python 3.8 from the test matrix.
@congwang09 https://github.com/atlanticwave-sdx/sdx-controller/pull/321 should resolve the broken test.
@congwang09 I don't understand the new test failure ("coveralls: command not found"??). It has nothing to do with anything we did. Please go ahead and merge this. Let us figure out the coveralls issue separately.
This is the issue: https://github.com/coverallsapp/github-action/issues/219.
Resolves: https://github.com/atlanticwave-sdx/sdx-controller/issues/172
When there's no topology in SDX controller, if place a connection, SDX controller will return "Could not generate a graph". This is a bit ambiguous. Making the message more clear as "No SDX topology found".
Also, since we are in development phase, changed default logging to DEBUG to get more logging when something goes wrong.