atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.64k stars 404 forks source link

History recorded after M-x set-url-new-nosave-buffer #3372

Open pretentious7 opened 2 months ago

pretentious7 commented 2 months ago

Describe the bug

I open a page in M-x set-url-new-nosave-buffer and then close the buffer, and close nyxt. The page is visible in history-all-query (C-M-b) upon reopening nyxt Precise recipe to reproduce the issue

  1. start nyxt
  2. run M-x set-url-new-nosave-buffer example.com
  3. M-x delete-current-buffer
  4. close browser
  5. open browser
  6. M-x history-all-query examp

You should now see example.com in the history

Information

ASDF version: 3.3.5 ASDF registries: (NYXT-SOURCE-REGISTRY ENVIRONMENT-SOURCE-REGISTRY USER-SOURCE-REGISTRY USER-SOURCE-REGISTRY-DIRECTORY DEFAULT-USER-SOURCE-REGISTRY SYSTEM-SOURCE-REGISTRY SYSTEM-SOURCE-REGISTRY-DIRECTORY DEFAULT-SYSTEM-SOURCE-REGISTRY) Critical dependencies: (/gnu/store/v1q4sy44h53vmgcxwr6v4gm1vad4cb2j-sbcl-cl-cffi-gtk-3.8.8-3.1700fe6/share/common-lisp/sbcl/cl-cffi-gtk/gtk/cl-cffi-gtk.asd /gnu/store/5llhygicxsfqwgrfhxnfal5v5y8a8f3g-cl-gobject-introspection-0.3-3.83beec4/share/common-lisp/source/cl-gobject-introspection/cl-gobject-introspection.asd /gnu/store/jn6pij610pip0bzx6ajqzcbr9lg7bmav-sbcl-cl-webkit-3.5.10/share/common-lisp/sbcl/cl-webkit/webkit2/cl-webkit2.asd)

Guix version: 

Output when started from a shell

[15:02:01] Source location: #P"/gnu/store/hgqw7pf1jvck5083a35r1095l92ajm4i-nyxt-3.11.5/share/nyxt/" [15:02:01] Loading Lisp file #P"/home/abhishek/.config/nyxt/auto-config.3.lisp". [15:02:01] Listening to socket: #P"/run/user/1000/nyxt/nyxt.socket" [15:02:01] Reload the buffer for no-script-mode to take effect. [15:02:03] Loading #P"/home/abhishek/.local/share/nyxt/auto-rules.lisp". [15:02:03] Loading #P"/home/abhishek/.local/share/nyxt/hostlist-stevenblack.txt". [15:02:04] Loading #P"/home/abhishek/.local/share/nyxt/history/default.lisp". [15:02:04] Restoring 1 buffer from history. [15:02:04] Reload the buffer for no-script-mode to take effect. ```
aadcg commented 2 months ago

@pretentious7 thanks for reporting.