search

atlassian / nucleus

A configurable and versatile update server for all your Electron apps
Other
398 stars 93 forks source link

fix(rpm): fix rpm signing on non-docker platforms #38

Closed leofidus closed 6 years ago

leofidus commented 6 years ago

The rpmsign command was failing when running nucleus without docker. The cause was inconsistent quoting of command line arguments. This change makes argument quoting the responsibilty of getSignRpmCommand instead of its caller, making it consistent with all other similar functions.

ISSUES CLOSED: #34

The actual cause of the bug was that yum.ts line 63 was quoting an argument, but the way the argument is called in the linux code path already takes care of quoting, leading to double quoting.

leofidus commented 6 years ago

Updated to address your review

MarshallOfSound commented 6 years ago

Code looks 🆗

Can you sign the CLA --> https://github.com/atlassian/nucleus#contributors

leofidus commented 6 years ago

done

leofidus commented 6 years ago

Is there a problem with the CLA I signed?

MarshallOfSound commented 6 years ago

Sorry for the delay @leofidus we're working on automating our CLA stuff but for now the manual process is tedious 😄