search

atlassian / nucleus

A configurable and versatile update server for all your Electron apps
Other
398 stars 93 forks source link

Allow armv7l and multiple arch uploads for linux #79

Open raduburla opened 5 years ago

raduburla commented 5 years ago

Hello,

I need to allow uploads for an armv7l build (Raspberry) but nothing is uploading and no error is shown. The x64 arch file uploads successful.

I searched for a fix and found that armv7l files are ignored and the execution stops https://github.com/atlassian/nucleus/blob/36117b029b513821960c35bf1d1b6e465ae66581/src/files/Positioner.ts#L76-L78

And only one type of arch can be uploaded, if I upload the armv7l build and after the x64 one, the last one is ignored. After some testing the issue seems to be here. https://github.com/atlassian/nucleus/blob/36117b029b513821960c35bf1d1b6e465ae66581/src/db/BaseDriver.ts#L8

Instead of .deb should be 'amd64.deb', 'armhf.deb', 'i386.deb, the same should be for rpm.

I'l soon submit a PR with fixes for this issue