When you upload a release with a space in the name, the route that serves draft releases truncates the file name.
This happens because the file name isn't being escaped, so the Content-disposition directive ends with the space in the file name, and the rest of the file name is ignored by the browser.
After applying this fix, "draft" downloads with spaces in their names are able to be downloaded correctly.
I didn't see any tests for these endpoints, so I didn't add new ones (which would require some test app fixtures), but let me know if you'd prefer to have a test for this fix and I'll look at adding one
When you upload a release with a space in the name, the route that serves draft releases truncates the file name.
This happens because the file name isn't being escaped, so the
Content-dispositiondirective ends with the space in the file name, and the rest of the file name is ignored by the browser.The HTTP spec states that filenames should be quoted strings, so this PR
JSON.stringifys the file name, which effectively quotes it.After applying this fix, "draft" downloads with spaces in their names are able to be downloaded correctly.
I didn't see any tests for these endpoints, so I didn't add new ones (which would require some test app fixtures), but let me know if you'd prefer to have a test for this fix and I'll look at adding one