Improve JSON serialization compatibility of User

atmos / warden-github

:lock: warden strategy for github oauth

MIT License

54 stars 41 forks source link

Improve JSON serialization compatibility of User #49

Closed fphilipe closed 8 years ago

fphilipe commented 8 years ago

Previously, the MembershipCache was a subclass of Hash. When serializing to and deserializing from JSON, the MembershipCache would become a Hash and blow up. This is a problem in warden-github-rails where I switched to a custom warden (de)serialization in order to properly support JSON serialization and also to support mocked users in test environments between requests (relevant warden-github-rails commit).

atmos commented 8 years ago

Hi @fphilipe! Have you tested this in a production application? I can cut a release if this fixes stuff for you.

fphilipe commented 8 years ago

Hey @atmos. Yeah, I'm using this in production right now. My latest version of warden-github-rails doesn't play well with warden-github in combination with rails' json cookie serializer (marshal works just fine). I'd appreciate a new cut 😉

atmos commented 8 years ago

1.3.0 is up on rubygems.