markdown-it-footnote support

atom-community / markdown-preview-plus

Markdown Preview + Community Features

https://atom.io/packages/markdown-preview-plus

Other

370 stars 85 forks source link

markdown-it-footnote support #454

Closed jorisvanzundert closed 5 years ago

jorisvanzundert commented 5 years ago

[x] I have looked over the contribution guide, which contains some crucial technical information.

Hi,

I added markdown-it-footnote support as requested in #433

I'm new to the project, so there may be caveats and spec or style issues that I missed. Modules and code should be in sync with the upstream master.

Happy to hear if this is useful and/or if it needs changes.

All best --Joris

lierdakil commented 5 years ago

LGTM, thanks for your work!

HanSeoulOh commented 5 years ago

Just to confirm, 0/2 checks passed means that this feature is still not available, correct?

jorisvanzundert commented 5 years ago

It has been merged, but not released yet I think. And it looks like something fails in the build, but I am unclear on what exactly. Maybe @lierdakil knows what's up?