search

atom / atom-keymap

Atom's selector-based keymap system
MIT License
105 stars 58 forks source link

Coffeelint support #158

Closed ghost closed 8 years ago

ghost commented 8 years ago

Add coffeelint support!

nathansobo commented 8 years ago

Okay once this build goes green I'm comfortable merging it.

ghost commented 8 years ago

I think use Coffeelint better than grunt-coffeelint, your code cleaner and more consistent, you can see https://travis-ci.org/atom/atom-keymap/builds/168703887. You can control your dependency packages with Dependency Status Badge. And it will consistency with other package in Atom. Do you think so @nathansobo?

nathansobo commented 8 years ago

Yeah, makes sense. Just need a green build and I'm happy to merge it.

ghost commented 8 years ago

I will complete it when I can!

thomasjo commented 8 years ago

Why are you replacing all valid usage of @something with this.something?

ghost commented 8 years ago

Oh I think should update coffeelint rather than replace @something with this.something. I will revert all.

ghost commented 8 years ago

@nathansobo I cleaned everything!

nathansobo commented 8 years ago

@torn4dom4n Wow. Thanks so much! Awesome work! Please feel free to make similar contributions elsewhere.

ghost commented 8 years ago

:heart: