atom / atom-keymap

Atom's selector-based keymap system
MIT License
105 stars 58 forks source link

[WIP] Convert coffee to JS #166

Closed Rokt33r closed 8 years ago

Rokt33r commented 8 years ago
Rokt33r commented 8 years ago

@nathansobo I think I should wait until review. I'm afraid if I've gone faraway. Please check, then I'll fix it and continue the work. 😀

nathansobo commented 8 years ago

Hey @Rokt33r. Yikes. Looks like we had a miscommunication on our end. Unfortunately @iolsen's io-modifier-keyups branch was not current with master when you started your work, and you're going to need to merge master into your branch. I'm really sorry.

iolsen commented 8 years ago

Shoot that's my fault. I think the changes since my last merge with master are minor. Let me know if I can help.

Rokt33r commented 8 years ago

@nathansobo @iolsen I'm okay. 😭 I'll start again from master branch after I wake up. Btw, how should I move the comments? Is there any guidance for it?

iolsen commented 8 years ago

I've merged master into io-modifier-keyups again so that branch is still (again) the right basis for this conversion.

Rokt33r commented 8 years ago

@iolsen Great, I'll pull it again! 😁

iolsen commented 8 years ago

Really sorry about that. Thanks for your work on this!

Rokt33r commented 8 years ago

I created another branch, https://github.com/atom/atom-keymap/pull/168, to start from master.