Closed Rokt33r closed 8 years ago
@nathansobo I think I should wait until review. I'm afraid if I've gone faraway. Please check, then I'll fix it and continue the work. 😀
Hey @Rokt33r. Yikes. Looks like we had a miscommunication on our end. Unfortunately @iolsen's io-modifier-keyups
branch was not current with master
when you started your work, and you're going to need to merge master into your branch. I'm really sorry.
Shoot that's my fault. I think the changes since my last merge with master are minor. Let me know if I can help.
@nathansobo @iolsen
I'm okay. 😭 I'll start again from master
branch after I wake up.
Btw, how should I move the comments? Is there any guidance for it?
I've merged master into io-modifier-keyups
again so that branch is still (again) the right basis for this conversion.
@iolsen Great, I'll pull it again! 😁
Really sorry about that. Thanks for your work on this!
I created another branch, https://github.com/atom/atom-keymap/pull/168, to start from master
.