Only cancel selection when Atom has focus

atom / atom-select-list

An etch component to show select lists with fuzzy filtering, keyboard navigation and other cool features.

MIT License

33 stars 33 forks source link

Only cancel selection when Atom has focus #1

Closed winstliu closed 7 years ago

winstliu commented 7 years ago

Re-implementation of https://github.com/atom/atom-space-pen-views/pull/18 to fix https://github.com/atom/atom/issues/1918 again. I confirmed that this fix works by testing it out on encoding-selector.

Please inform me if I should add a spec.

as-cii commented 7 years ago

Thanks for the fix, @50Wliu! It's super appreciated! ❤️ If it's not too hard to add a test for this, it would be really great if you could add one. ✨

winstliu commented 7 years ago

Test added and passes on my machine. Had to bring in sinon because I don't know how to programmatically make the window lose focus.

as-cii commented 7 years ago

Thanks, @50Wliu! This was published in 0.1.0. 🎉

It would be awesome if you could also upgrade atom-select-list across all Atom repositories that use it. In particular, it would be nice if we could add it as ^0.1.0 in each package's dependencies section, so that npm will be able to dedupe it during script/bootstrap.