search

atom / etch

Builds components using a simple and explicit API around virtual-dom
MIT License
555 stars 57 forks source link

update-props.js:27 Uncaught TypeError: Cannot use 'in' operator to search for '0' in white-space: pre-wrap; #45

Closed joefitzgerald closed 7 years ago

joefitzgerald commented 7 years ago
screen shot 2017-03-05 at 10 40 10 pm

Affected in 0.9.0 > 0.9.2. Was not an issue in 0.8.0, and reverting fixes the issue.

thomasjo commented 7 years ago

I think a minimal repro example would be beneficial (if not necessary). Also, from your description I'm not entirely sure if this is a problem in the entire 0.9.x range, or just 0.9.2. I suspect what you meant the former.

There's been 54 commits since 0.8.0, so it's extremely like that there have been breaking changes caused by e.g. switching away from the virtual-dom library, or related changes.

nathansobo commented 7 years ago

@joefitzgerald Are you passing style as a string?

nathansobo commented 7 years ago

0.9.4 should address this issue.

joefitzgerald commented 7 years ago

Yep, style is being passed as a string.