Consider testing with newer Electron - Githubissues

atom / etch

Builds components using a simple and explicit API around virtual-dom

MIT License

555 stars 57 forks source link

Consider testing with newer Electron #86

Closed DeeDeeG closed 4 years ago

DeeDeeG commented 4 years ago

Summary

Update the electron devDependency in package.json, so tests and CI run against a newer version of Electron.

Motivation

I expect testing on newer Electron is good idea, to make sure this package still works in the latest Electron apps.

Describe alternatives you've considered

Keep testing against Electron v1.x?

Additional context

This package currently tests against Electron ^v1.7.11.

The latest stable Electron is v9, soon to be v10 in August 2020.

Atom is on Electron v5.0.13. Hopefully, soon to be v6.1.12.

DeeDeeG commented 4 years ago

I have a branch that does this; If you'd like it neatened up and submitted as a pull request, I'd be happy to do that.

https://github.com/DeeDeeG/etch/blob/electron-mocha-bump/package.json#L37-L38

Passes CI: https://travis-ci.com/github/DeeDeeG/etch/builds/176169692