search

atom / language-gfm

GitHub Flavored Markdown in Atom
MIT License
101 stars 108 forks source link

feat: add 'properties' support #149

Closed ldez closed 6 years ago

ldez commented 8 years ago

add support for 'properties' source.

I use java-properties but it's possible to use git-config for a better support. What do you think ?

GitHub use git-config as support for the properties marker:

[user]
    name = John Doe
    email = example@examplecom
ldez commented 6 years ago

Any news?

daviwil commented 6 years ago

Hi @ldez! Thanks a lot for the PR. If you think using git-config will lead to a better result, please give it a try. Could you also add a test to ensure that the language gets parsed correctly?

daviwil commented 6 years ago

Thanks a lot for making those changes! The tests are green, think this is ready to go?

ldez commented 6 years ago

Do you want me to add more tests?

daviwil commented 6 years ago

Only if there's something else you feel is worth testing. Looks like you've added similar tests as the ones for other embedded languages, so I think it should be sufficient.

ldez commented 6 years ago

Ok seems good to me.

FYI:

daviwil commented 6 years ago

Thanks a lot for the comparison! Definitely better to go with git-config, it seems. I'll merge this now and ship an update to be included with 1.29.0-beta0 🎉