search

atom / language-gfm

GitHub Flavored Markdown in Atom
MIT License
101 stars 108 forks source link

language regex leaks outside code block #171

Open luxedo opened 8 years ago

luxedo commented 8 years ago

I've found that in java, javascript and css (probably there's more), if a block of a statement is not closed, the regex will leak and stop language-gfm from capturing the end of a code block.

leak

dead-claudia commented 8 years ago

I have exactly the same problem, but with question marks, which makes documenting optional parameters without a default a pain because of the lack of syntax highlighting for the Markdown itself.

screenshot from 2016-10-24 23-47-59

dead-claudia commented 8 years ago

It doesn't appear language-specific, though. This is with a JavaScript file:

screenshot from 2016-10-24 23-52-48

sriharshachilakapati commented 7 years ago

This also happens with yaml code blocks, where even blocks are not created at all, even in the open space.

issue

It should stop after the small code block, with only development: true in it. It even appears on backticks as well.

tomjoht commented 7 years ago

I reported the issue with YAML code blocks here and also included some screenshots.

dead-claudia commented 7 years ago

Filed atom/atom#13515. Not a language-gfm issue, as I noted previously.

dead-claudia commented 7 years ago

Take 2: atom/first-mate#83.