search

atom / language-go

Go language package for Atom
Other
106 stars 65 forks source link

Add support for Go module and checksum files #156

Closed brainsnail closed 5 years ago

brainsnail commented 6 years ago

Description of the Change

In Go 1.11 a new language feature was added called modules. These exist to support removing $GOPATH, encourage repeatable builds and semantic versioning your Go packages. If you want to dig further into what they are, I think the Go team did a great job in their documentation and in the community wiki.

This particular change to the Atom language-go package is to add the two new file types that modules introduced.

Those files are:

Alternate Designs

No particular alternatives stood out.

Benefits

When viewing module and checksum files the version numbers will be highlighted along with the commit hashes. There's some other stuff - like keyword highlighting - that makes it feel a little more polished.

Possible Drawbacks

More regular expressions to maintain for version numbers and checksums.

Applicable Issues

152 - huge thank you to @pd93 for working on this with me

rsese commented 6 years ago

Thanks! Someone from the team will take a look as soon as they can.

lee-dohm commented 6 years ago

@ckaznocha Because of your experience with Go, would you mind reviewing this PR and make sure it won't cause any regressions?

nathansobo commented 5 years ago

Cool. Seems like a nice change. Thanks. Sorry for the wait.