search

atom / language-java

Java package for Atom
Other
62 stars 59 forks source link

Wrong highlighting in member-variables #177

Closed snjeza closed 5 years ago

snjeza commented 6 years ago

Signed-off-by: Snjezana Peco snjezana.peco@redhat.com

Requirements

Description of the Change

Fixes highlighting in member-variables. For more details and examples see https://github.com/redhat-developer/vscode-java/issues/707.

Alternate Designs

None were considered, since it is fairly simple fix.

Benefits

Fixes highlighting in member-variables.

Possible Drawbacks

None.

Applicable Issues

Fixes #169 Fixes #176 Fixes redhat-developer/vscode-java#707

sadikovi commented 6 years ago

Does it handle the case when it is just a variable, not necessarily a class property? Can you also add a unit test that verifies the fix? Thanks.

snjeza commented 6 years ago

Does it handle the case when it is just a variable, not necessarily a class property?

The issue happens only when it is a class property.

Can you also add a unit test that verifies the fix?

I will try.

sadikovi commented 5 years ago

I don't think this patch actually fixes the issue.