Underscore "_" not recognized inside type qualifier

atom / language-java

Java package for Atom

Other

62 stars 59 forks source link

Underscore "_" not recognized inside type qualifier #198

Closed felixhao28 closed 5 years ago

felixhao28 commented 5 years ago

Description

When a type qualifier starts with "_", it breaks the grammar for the rest of the line.

Fix

I replaced all [A-Za-z]\\w* to [a-zA-Z$_][\\.a-zA-Z0-9$_]*, and (\\w+\\.)*[A-Z]+\\w* to ([a-zA-Z$_][a-zA-Z$_0-9]*\\.)*[A-Z]+\\w*) it seems fixed.

sadikovi commented 5 years ago

Thanks. I will take a look.

sadikovi commented 5 years ago

@felixhao28 would you like to submit a patch? I am a bit snowed under at the moment, would appreciate if you could help out, plus, you seem to have fixed it already!

felixhao28 commented 5 years ago

Although I have been a maintainer of several TextMate syntax-based plugins for a few years, I am still not confident messing with syntax files I am not familiar with.