atom / language-javascript

JavaScript language package for Atom
Other
194 stars 236 forks source link

use improved for loop #636

Closed Ali-00-Ridha closed 5 years ago

Ali-00-Ridha commented 5 years ago

Prerequisites

Description

this atom extension/package uses the old for loop: for (var i = 0; i < array.length; i++) { array[i] }

Another option is Insert improved for loop like this: for (var i = array.length - 1; i >= 0; i--){ array[i] };

Steps to Reproduce

  1. open .js file
  2. type (for)
  3. from keyboard press (tab)

Expected behavior: expecting the improved for loop: for (var i = 0; i < array.length; i++) { array[i] }

Actual behavior: old bad/overhead for loop code: for (var i = 0; i < array.length; i++) { array[i] }

Reproduces how often: 100% of the time

Versions

latest atom version Atome: 1.34.0 x64 Electron: 2.0.16 Chrome: 61.0.3163.100 Node: v8.9.3

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

rsese commented 5 years ago

Thanks for contributing @Ali-00-Ridha! As detailed in https://github.com/atom/language-javascript/pull/637#issuecomment-456902494, we're going to keep things as is for now so we'll go ahead and close this issue too.