atom / language-javascript

JavaScript language package for Atom
Other
194 stars 236 forks source link

Allow folding switch_default #644

Closed Ben3eeE closed 5 years ago

Ben3eeE commented 5 years ago

Requirements

Description of the Change

case statements in javascript are parsed as: switch_statement > switch_body >switch_case

Default case statements in javascript are parsed as: switch_statement >switch_body > switch_default

This PR adds switch_default to the folding rules so default can be folded with the same rule as case.

Alternate Designs

N/A

Benefits

Consistent folding rules for switch statements

Possible Drawbacks

Someone likes unfoldable default and will open an issue that they can now fold it

Applicable Issues

N/A

Verification Process

const fun = () => {
  switch (variable) {
    case DO_STUFF:
      do_stuff();
      break;
    case DO_OTHER_STUFF:
      do_other_stuff();
      test();
      break;
    default:
      do_stuff();
      test();
      break;
  }
};
nathansobo commented 5 years ago

:heart: This will be nice.