Snippets: Rails 5 uses new base class conventions: ApplicationMailer & ApplicationRecord

atom / language-ruby-on-rails

Ruby on Rails package for Atom

Other

48 stars 41 forks source link

Snippets: Rails 5 uses new base class conventions: ApplicationMailer & ApplicationRecord #44

Closed defeated closed 8 years ago

defeated commented 8 years ago

Using Rails 5.0.0 beta, I noticed some snippets stopped working. This PR updates the following:

meta.rails.model to alternatively look for the new ApplicationRecord convention
meta.rails.mailer to alternatively look for the new ApplicationMailer convention

50Wliu commented 8 years ago

Can you include some tests for this please? Thanks!

defeated commented 8 years ago

@50Wliu I wanted to, but it looks like theres no existing tests for Snippets in this package, only:

https://github.com/atom/language-ruby-on-rails/blob/master/spec/grammar-spec.coffee

Do you have a way to test for regressions?

defeated commented 8 years ago

@50Wliu OK, I looked at atom/language-ruby package for some inspiration. I've added a new spec/snippets-spec.coffee file and it is passing under apm test. Let me know what you think!

50Wliu commented 8 years ago

Awesome, thanks for this!