Inconsistency on percent string symbol syntax using Tree-sitter

foreverqihe commented 5 years ago

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

The symbol syntax doesn't get rendered correctly: using Tree Sitter

NOT using Tree Sitter

Edit by @rsese with scope screenshots:

it does seem like the tokens should be scoped as symbols?

percent-string-symbols

symbol

Steps to Reproduce

Open Atom
Open a Ruby file
write code show as the snapshot

Expected behavior: [The color should be consistent as the syntax is an alternative syntax for symbol in Ruby so it should be the same color as other symbols]

Actual behavior: [using Tree Sitter, when we write the symbol with the %i syntax, the color changed to brown]

Reproduces how often: [Always]

Versions

Atom : 1.32.2 Electron: 2.0.9 Chrome : 61.0.3163.100 Node : 8.9.3 Windows 7

Additional Information

rsese commented 5 years ago

Thanks for the report - it does seem like the tokens should be scoped as symbols?

percent-string-symbols

symbol

Not 100% sure but we'll ask the team to take a look.

jasonrudolph commented 5 years ago

This is resolved as of https://github.com/atom/language-ruby/pull/271, so I'm gonna close this out. You can see the changes below. 😅

Atom 1.40.0 (current stable release)

Atom 1.42.0-nightly2 (current nightly release)

atom / language-ruby