atom / language-yaml

YAML package for Atom
Other
24 stars 39 forks source link

Comment color resets for long comment lines #110

Closed mcandre closed 5 years ago

mcandre commented 5 years ago

Prerequisites

Description

The color for syntax highlighting comments, halts in the middle of a long comment line and resets to a different color.

Steps to Reproduce

  1. Write a YAML file with long lines (~2048 ASCII characters).
  2. Comment the line.

Expected behavior:

The entire line is rendered with the user's preferred comment color.

Actual behavior:

A significant remainder of the line is highlighted with a different color.

Reproduces how often:

Always

Versions

$ apm --version
apm  2.1.7
npm  6.2.0
node 8.9.3 x64
atom 1.38.2
python 2.7.15
git 2.18.0

$ atom --version
Atom    : 1.38.2
Electron: 2.0.18
Chrome  : 61.0.3163.100
Node    : 8.9.3
calebmeyer commented 5 years ago

Thanks for taking the time to contribute!

We noticed that this is a duplicate of https://github.com/atom/atom/issues/1667. You may want to subscribe there for updates.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.

For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.