Suggestion: Add support for Terminal themes apart from color schemes

griimick commented 1 year ago

Terminal themes are now available in Preview. https://learn.microsoft.com/en-us/windows/terminal/customize-settings/themes

I suggest the following,

Add support for terminal "themes" and "color schemes" separately. Currently what we call themes in this project can be termed "color schemes". Themes define colors for Tabs and Tab Row
Have a separate JSON of themes apart from color schemes and use them accordingly.
Modify the terminal window used to preview color schemes to be more in sync with Windows Terminal design.

Let me know what you think.

atomcorp commented 1 year ago

Thanks for the heads up! All sounds great and welcome. PRs welcome too but if I get round to a refactor of this project I'll be sure to put it in myself.

griimick commented 1 year ago

Sure! I will definitely submit a draft PR first if I start on any of them. Thanks for the project :)

atomcorp / themes

Suggestion: Add support for Terminal themes apart from color schemes #87