search

atomheartother / QTweet

A qt Discord bot who cross-posts from Twitter to Discord
GNU Affero General Public License v3.0
96 stars 71 forks source link

Publish Docker image onto Docker Hub #75

Closed saitho closed 4 years ago

saitho commented 4 years ago

I noticed you're providing a Dockerfile but I couldn't find a Docker image on Docker Hub. Can you publish one, so that for setting up a custom instance of QTweet one can directly pull the container without having to clone the repository?

atomheartother commented 4 years ago

You know, this is one of those things I keep saying I'll eventually do and never actually end up doing. I'll do it right now, but i'll also write some documentation to do it with this method so it might take longer than just "push it".

saitho commented 4 years ago

One could set up a CI workflow that automatically publishes to Docker Hub when a new release is created. You could use GitHub actions for that. :) If you need help I could also send that as PR, I've already done that.

atomheartother commented 4 years ago

Absolutely submit that PR, it'll save me time ^^ I already have a docker account so it'll only be a matter of linking the repos

saitho commented 4 years ago

Oh right, you can set that up within Docker Hub. It now also has build rules which enable building from tagged releases. Simply creating a new repository on Docker Hub and linking it to this one should do the trick. No need of any additional configuration in the repository.

atomheartother commented 4 years ago

Yep, i just thought there were changes to do in the repo but I guess not! Ok lemme give this a shot and I'll get back to you ^^

atomheartother commented 4 years ago

Ah wait, we're gonna run into a problem, QTweet currently relies on .env values fed through docker-compose in its build process, so i do need to change a few things.

saitho commented 4 years ago

Adding a VOLUME on the root directory should enable one to mount an .env file via Docker Compose or docker run.

atomheartother commented 4 years ago

Oh no, i mean the env is necessary at build time, and don't worry i fixed it, as much as it can be fixed anyway.

Updated documentation: https://docs.google.com/document/d/1LGxfhxptioc653pqJaY5owwpZmzTg4rggqwBYcgO73I/edit#heading=h.anaydnlsghus

Let me know if it works, obviously this is untested.

saitho commented 4 years ago

Yes, works fine. Thanks!