search

atomjack / cmbot

A full featured bot for turntable.fm
59 stars 18 forks source link

Feature Request: Convert to plug.dj? #71

Open Psykoral opened 10 years ago

Psykoral commented 10 years ago

With the sad announcement that turntable.fm DJ rooms are going away on DEC 2nd, have you given any thought to converting CMBot to a component for the similar http://plug.dj service?

I'd be happy to help out in such a conversion :c)

atomjack commented 10 years ago

Yeah I would definitely like to port CMBot over to Plug.dj, but unfortunately I haven't yet been able to find a working API for doing bots on Plug. There is an API at https://github.com/chrisinajar/plugapi, but it appears that an update to Plug some time back has made broken the API. There is a Plug user who has started working on the API to see if he can get it working, and if he does I will immediately start working on a Plug version of the bot. I'll keep ya posted of our progress.

Psykoral commented 10 years ago

There is at least a nodejs API for it already https://npmjs.org/package/plugapi (EDIT: Oh, looks similar to the Github you posted) . Not sure we can tell how well / extensive it is just by that slim documentation on it, but it's a start. That page lists a few bots that are currently in use using that npm module, so I guess it works in some fashion.

That, combined with the plug.dj API docs should at least give us a good start, no? http://support.plug.dj/entries/30455216-Documentation

atomjack commented 10 years ago

Yeah that's the same one that I linked to, you just linked to the npm version. It's not working due to a Plug update.

diginc commented 10 years ago

I drew the same conclusion as atomjack when looking into API/Bots for plug this weekend. Plug's update broke a the currently written API which a lot of bots relied on and no one is fixing the API library.

Maybe the way to find working code now is just asking around plug.dj rooms to see what working bots (if there are any) use for their API (hopefully node).

Psykoral commented 10 years ago

Yeah it looks like those rooms referenced on those Git pages are empty :c( You may be right that we might have to just ask around to see if any manager bots are even written anymore.

diginc commented 10 years ago

I looked at the existing "API" and it appears it is just javascript based for extensions, I think to run a bot it'd have to be in a browser like through XVFB...not sure what the equivilent to that is in node...or from your own browser - which is how the old Node.js bot appears to have operated based off the docs I read.

There is a feature request for a REST API with no staff responses on Plug's support portal too.

Psykoral commented 10 years ago

https://npmjs.org/package/phantomjs is what I use to "fake" browsers. Runs pretty well from my experience, but I guess it really depends on what you need to accomplish.

Psykoral commented 10 years ago

looks like documentation on their API was updated yesterday too. Maybe this is something we could work with? http://support.plug.dj/entries/30455216-Documentation

unkl commented 10 years ago

interested as well.

Atomjack, thanks for all your help though. Much appreciated.

atomjack commented 10 years ago

I forked the PlugAPI and have gotten it to work, and am currently working on porting cmbot over to Plug, but it's going to be a long process. I'm having to pretty much re-implement each command one at a time, reusing a lot of code but altering a lot of it.

Here's my fork of the API: https://github.com/atomjack/plugapi

diginc commented 10 years ago

You are awesome sir, I'm more than happy to bug test and or squash if you need help.

On Tue, Dec 3, 2013 at 3:51 PM, Chris Bellew notifications@github.comwrote:

I forked the PlugAPI and have gotten it to work, and am currently working on porting cmbot over to Plug, but it's going to be a long process. I'm having to pretty much re-implement each command one at a time, reusing a lot of code but altering a lot of it.

Here's my fork of the API: https://github.com/atomjack/plugapi

— Reply to this email directly or view it on GitHubhttps://github.com/atomjack/cmbot/issues/71#issuecomment-29755210 .

Psykoral commented 10 years ago

Seriously awesome! Let me know if I can be of any help, or when it's in a spot to begin preliminary testing.

Psykoral commented 10 years ago

Forked your repo, got it up & running (on Windows no less!) http://plug.dj/plur-electronica/. Haven't gotten any of the fancy stuff like tweeting & auto wooting running yet (any hints there?), but I added a few commands to my bot.js to make him DJ automatically and reconnect if it's errors out.

Been making a few minor edits and updating dependencies & whatnot. Created a pull request for ya :c)