atorus-research / datasetjson

Read and write CDISC Dataset JSON files
https://atorus-research.github.io/datasetjson/
Apache License 2.0
12 stars 2 forks source link

Make schema validation optional or remove schema validation from read and write step #26

Closed mstackhouse closed 7 months ago

mstackhouse commented 10 months ago

On large file, schema validation can become prohibitive. So need away to bypass this to save the computational time.

nicholas-masel commented 8 months ago

@mstackhouse What do you think here? Optional or remove from read/write?

mstackhouse commented 8 months ago

I'd say just remove completely from read and write. There's limited added benefit of doing it on read, because if reading fails you can run the validator (which is what that error tells you to do anyway). And we're the ones writing out the file so I don't really think we need to run a validate on it.