search

atoum / AtoumBundle

This bundle provides a simple integration of atoum into Symfony 2.
MIT License
45 stars 25 forks source link

Loop support #68

Closed Djuuu closed 7 years ago

Djuuu commented 10 years ago

The lack of "loop mode" is the first thing I noticed with this bundle.

I have overriden mageekguy\atoum\scripts\runner::loop() to kind of fix the passthru() call, calling back the Symfony command. As arguments/options handling of atoum and symfony commands is a bit different, I simply and roughly fed back all the original options and arguments to the command, handling only score file as in the original loop() function.

I guess this is a bit dirty, and I don't know everything I'm doing :dog:

jubianchi commented 10 years ago

:+1: thanks for this patch.

It would be awesome if the bundle could support every atoum CLI arguments. I have some dirty WIP to do this. Until I can make my branch clean, I'll merge your patch. I'll try to review this one ASAP.

jubianchi commented 7 years ago

closed in favor of #104.

Thanks @Djuuu!