improve third party integration section

atoum / atoum.github.io

Atoum website

http://atoum.github.io

2 stars 8 forks source link

improve third party integration section #12

Closed agallou closed 8 years ago

agallou commented 8 years ago

add some logos
categorize the tools
add some text between those
add link on how to integrate those tools

Before : capture d ecran 2016-01-09 a 00 58 52

After: capture d ecran 2016-01-09 a 00 58 36

Hywan commented 8 years ago

Too fast for the merge @Grummfy :-). Logos must be in SVG (see http://svgporn.com/). CSS is not correctly indented. Text is not correct too.

@Grummfy Can you revert the PR?

jubianchi commented 8 years ago

@Hywan we are not going to revert it does not make sense. We will fix what we can fix ;)

agallou commented 8 years ago

@Hywan : PR made to use svg (#15) For CSS I haven't seen there were a logic in the css indent. just though there were intendation problems (not used to have indentation in css,only in scss/less). I we'll made a PR to fix that (could be usefull to indicate that in a CONTRIBUTING file). Could you list what's not correct in the text ?

Hywan commented 8 years ago

@agallou I will try to make a PR to fix CSS. That's 4 spaces for a level of indentation, that's all. We can add a level of indentation if we are declaring properties for sub-components.