Closed sachins-geekyants closed 2 years ago
I have faced the similar issue, While I am trying to add contact on @mosphere pro app, The contacts is not getting added also it results below exception
Analysed the code and found the root cause of the issue. The issue occurs only in iOS devices. When an app in iOS is uninstalled the local storage gets cleared but the keychain remains as is. Hence, during onboarding the app gets the data from the key-chain manager. But in onboard
method in at_client_service.dart
, we do not have the logic to persist the keys from key-chain manager to local storage.
As a temporary fix, calling persistKeys
in onboard method in at_client_service.dart after line no. 220 resolved the issue.
@kalluriramkumar is this fix available to test by pointing to any branch ?
@sachins-geekyants I just spoke to @kalluriramkumar - he has fix in local branch which resolves this, and he will be raising a PR shortly
Going to add this into the current sprint as it looks important to resolve for the next AtmospherePro release
@sachins-geekyants Sita's created the PR #473 branch https://github.com/atsign-foundation/at_client_sdk/tree/persist_keys
@kalluriramkumar previously in this ticket you said, "As a temporary fix, calling persistKeys in onboard method in at_client_service.dart after line no. 220 resolved the issue."
Does Sachin still need to do that, or does this PR fix the issue such that your suggested temporary fix is no longer needed?
@kalluriramkumar previously in this ticket you said, "As a temporary fix, calling persistKeys in onboard method in at_client_service.dart after line no. 220 resolved the issue."
Does Sachin still need to do that, or does this PR fix the issue such that your suggested temporary fix is no longer needed?
This PR fixes the issue and the temporary fix is not needed.
@sachins-geekyants once you've done a test against at_client trunk to verify this fix, we can publish a new at_client package version which includes this fix
It's working fine with the trunk branch.
The fix is published in at_client_mobile: ^3.1.12.
Describe the bug I onboarded with @ minorgettingplayed7 on @ mosphere pro , when tried to add contact I started getting exception in encryption service and contact was not added.
Exception: Self encryption key is not set for atsign @minorgettingplayed7
after resetting the keychain and onboarding again I did not got this issue and was able add contacts. This behaviour was seen on multiple devices while testing.
Expected behavior contact should be added without any encryption exception.
Screenshots
Were you using an @application when the bug was found?