NPT_Flutter shows disconnected but it is not

atsign-foundation / noports

Connect to any device with no external listening ports open

https://noports.com

BSD 3-Clause "New" or "Revised" License

272 stars 15 forks source link

NPT_Flutter shows disconnected but it is not #1572

Closed cconstab closed 1 day ago

cconstab commented 5 days ago

Describe the bug

Connected to remote webserver which continued to be connected but the GUI said disconnected

Steps to reproduce

1.Unknown

Expected behavior

Display the actuall connectivity status ?

Screenshots

See attached video

https://github.com/user-attachments/assets/9b106141-1d0b-472b-89e9-0262703c7890

Smartphones

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Were you using an atApplication when the bug was found?

No response

Additional context

No response

XavierChanth commented 5 days ago

I tested this quite thoroughly when I implemented, and I can see that the SocketConnector close is called in the app logs. My assumption is that the changes to socket connector are making the connection wait for the server side to close. Since we aren’t killing a process like we do for the binaries, it’s only affecting the app using latest socket connector. Will investigate to confirm.

cconstab commented 5 days ago

Do we by default use the -K keep alive as I do not see that as an option.. I have tested again and it is repeatable

XavierChanth commented 4 days ago

It works a little differently, it didn't make sense to offer it. The built-in settings are pretty much identical to what -K does.

XavierChanth commented 4 days ago

It will not restart the connection on failure though