search

atsushieno / aap-core

an Audio Plugin Format/Framework for Android
MIT License
91 stars 3 forks source link

significant MIDI event dropout #178

Closed atsushieno closed 1 year ago

atsushieno commented 1 year ago

The commit 84afc34 seems to have brought in significant MIDI event dropout and now aapinstrumentsample misses a lot of note events, on both note on and note off.

atsushieno commented 1 year ago

It was actually fd1e00fa.

atsushieno commented 1 year ago

While refactoring the MIDI sequence merging code, I have brought in another bug that totally killed native in-plugin-process UI inputs. It's back, and the native UI inputs as well as Web UI inputs proved that there was no perf. issue. The changes around the new manager UI was regressive.

atsushieno commented 1 year ago

It was due to combination of (1) MIDI buffer sizing is miscalculated when there is AAPXS SysEx8, and (2) repetitive call to presetCount property in Compose PluginView always generates AAPXS SysEx8 which resulted in high occurrence of the problem (in other words we were lucky that the issue was easily reproduced...!).

The actual issue still persists but after making changes to the Compose presetCount the problem is not very visible anymore.

atsushieno commented 1 year ago

fixed at f9c46c2.