search

atsushieno / aap-core

an Audio Plugin Format/Framework for Android
MIT License
91 stars 3 forks source link

extension invocation on ACTIVE state freezes on *some* plugins #185

Closed atsushieno closed 1 year ago

atsushieno commented 1 year ago

It seems some plugins cause UI freezes and no further processing is performed e.g. "Start" > "Show Native UI" > freeze.

After the "freeze" it goes out of control; no note ons/offs are sent. No further extension calls are made.

Reproduced plugins:

atsushieno commented 1 year ago

aap-juce-obxd too, but it is rather due to #174. The thing is that we need further tweaks on projuce-app.sh.

atsushieno commented 1 year ago

It was most likely due to missing callback invocation, but to invoke the callback we need to pass requestId which is currently not doable within the API. We need to fix the API first.

atsushieno commented 1 year ago

It was not about missing callback, but due to missing MIDI output port that resulted in missing reply handling.

It is easy to fix this issue by adding MIDI output port, but it makes me wonder what we should do - maybe we should ALWAYS populate a MIDI port (actually both input and output), and treat manual port desgination as intent to process USER MIDI inputs and outputs.

atsushieno commented 1 year ago

The update ^ is implemented in aap-core, and thus aap-juce-adlplug-ae now works without further fix within itself.

Once we confirmed aap-juce-obxd works, this issue will be closed.

atsushieno commented 1 year ago

aap-juce-obxd, or any project that is based on Projucer, is effectively blocked by issue #174 and it is impractical to get this fixed right now. We go ahead without Projucer-based projects for now. Those projects that use Projucer are kind of outdated anyways.