Feature: add user-defined configuration options for machine disk size.

[Ciello89]

The user will have the ability to enter a disk size and modify the disk properties (for virtualbox users), in the config file. The minimum size must be 10GB and should be in GB. Virtualbox: An additional disk will be attached, in case the disk size requested is more than 10GB and the plugin vagrant-persistent-storage is required.

Closing-issue: #27

---

This change is 

[v1k0d3n]

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

---

Vagrantfile, line 24 at r1 (raw file):

# Install any Required Plugins
missing_plugins_installed = false
required_plugins = %w(vagrant-env vagrant-git vagrant-openstack-provider vagrant-proxyconf vagrant-persistent-storage)

@nadeemanwar can you ensure that jenkins is installing this plugin automatically? @ciello89 try deleting the plugin on your local machine and letting the vagrantfile install automatically. the gate is locked (review). it looks like the vagrant portion completed fine, but i want to make sure that some other issue isn't creeping into play.

---

Comments from Reviewable

[v1k0d3n]

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

---

a discussion (no related file): See notes

---

Comments from Reviewable

[nadeemanwar]

Look like the plugin got installed automatically in Jenkins. This is from the log Cloning into 'halcyon-kubernetes'... Submodule path 'halcyon-kubernetes': checked out 'b8843872b438c0ee307b9b54197de3fd244dc3ef' vagrant up --no-provision Installing the 'vagrant-persistent-storage' plugin. This can take a few minutes... Installed the plugin 'vagrant-persistent-storage (0.0.22)'! Bringing machine 'kube1' up with 'virtualbox' provider...

[att-comdev-bot]

Jenkins Build Failed after triggered by pull request

[v1k0d3n]

---

Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable

[att-comdev-bot]

Jenkins Build Failed after triggered by pull request

[v1k0d3n]

@nadeemanwar can we kick this one off again, or see if this completed successfully? do we need to revisit jenkins creds? i don't think we got back around to this since you were off for vacation.

[nadeemanwar]

Yes. I don't think we gave the write access to com-dev-bot user

[v1k0d3n]

@nadeemanwar can we kick this test off again?

[jwstein3400]

@v1k0d3n Can you please close and reopen so this will rekick our Jenkins CI?

[v1k0d3n]

@js5175 done :)

[att-comdev-bot]

Test

[jwstein3400]

rekick

[v1k0d3n]

@aric49 can you verify this works, and is an approach we want to go for the project? otherwise this will be outstanding for quite some time, or we'll need to let it drop and pick it up later.

[aric49]

I have validated the functionality of this PR, and everything looks good to me (LGTM!). I'm having a difficult time though understanding the use of this particular feature. Are you running disk size constraints in the kube VMs @Ciello89?

Of course, this might be a good feature to have in general in case users need to deploy the vagrant environment with custom disk sizes for particular use cases. I see no issue with including this functionality and merging the request. Any concerns @v1k0d3n?

[v1k0d3n]

@aric49 this feature was in fact requested by the community (to allow flexible disk sizes). and i don't have issues with the PR at all. when i checked it last, the update was fine but i had asked for some changes directly. let's pull this in so we can improve it some. for instance, L19: it should be 10GB of disk i believe. let's get in and make the changes needed.