search

att-comdev / halcyon-vagrant-kubernetes

Vagrant deployment mechanism for halcyon-kubernetes.
Apache License 2.0
12 stars 14 forks source link

Minor portability updates to scripts #55

Closed alop closed 7 years ago

alop commented 7 years ago

OS X is a popular developer platform, but sadly ships with BSD versions of many popular utils. In this script, getopt is not needed and is widely cited as bad form to use. sed proved to be a more challenging fix, as the BSD sed requires a newline after a command. This is easy to implement in an interactive shell, but proved to cumbersome inside a script. Instead, I chose to detect the OS, probe for the existence of gsed, and fail if it's not installed.

Lastly, the shell interpretter was malformed as a comment, and modern scripts are usually written with the interpreter not hardcoded.

Fixes #52

This change is Reviewable

retr0h commented 7 years ago

How do you all feel bout this @v1k0d3n @aric49?

alop commented 7 years ago

Added brew info to readme

v1k0d3n commented 7 years ago

All good now! Thanks @alop. @aric49 totally fine with this change. Able to merge. WAA.