search

attah / harbour-seaprint

🐟🖨 Network printing for Sailfish OS
GNU General Public License v3.0
16 stars 20 forks source link

Update harbour-seaprint-de.ts #50

Closed cnlpete closed 2 years ago

cnlpete commented 2 years ago

Added a few german translations

attah commented 2 years ago

Thank you for your contribution! As you may have seen, there is another PR outstanding for German translations. Have you coordinated? It looks like many of my comments there are not valid here.

cnlpete commented 2 years ago

Oh crap, i did not see that one :facepalm: I will check your comments and try to merge accordingly ...

cnlpete commented 2 years ago

I rebased my changes on the changes from #49, @wheelseal Feel free to look at these changes too

attah commented 2 years ago

Will do, thanks! I'll poke him elsewhere too - because i don't speak German, although Swedish helps with guessing some things.

cnlpete commented 2 years ago

I am unsure of the usage of the "utils" texts, they all appear to be lowercase in the english source texts, what context are they used in? (i.e. "main roll" - i am guessing some kind of paper source selection?)

attah commented 2 years ago

Right, i'm a bit blind to my own structure sometimes. All strings but one "Unknown" are in the ippName function. It maps enums and not-so-user-friendly names to translatable user-friendly ones.

Most will appear as choices when selecting options for a print job. But "job-state" and "printer-state" will appear on other pages, jobs and details pages respectively. I kept all choices lowercase, except the formats that are obviously names. If doing them capitalized is more appropriate for German, go right ahead - just be consistent. :)

cnlpete commented 2 years ago

@attah if you compare my changes against #49 (https://github.com/wheelseal/harbour-seaprint/compare/master...cnlpete:german-translations) you can see that i changed a few Uppercase/lowercase occurrences and also corrected a few typos

I am still unsure of how to translate all the ipp option strings, therefore i did not really touch those...

Even though it might not be at 100%, i think it is still a bit better than having a mixture of english and german texts

attah commented 2 years ago

Hmm, i see diff for things that were corrected on both PRs... i'll double-check locally.

cnlpete commented 2 years ago

i rebased my changes on #49, so it includes all the commits from wheelseal. please check the diff link for the changes to wheelseals branch

attah commented 2 years ago

Thanks, that looks much more like expected. Merging.