attickdoor / XIVComboPlugin

Plugin version of the icon replacement features in dalamud
GNU General Public License v3.0
181 stars 281 forks source link

[RPR] General Reaper combo suggestions (and a minor issue). #113

Open SacchiHikaru opened 2 years ago

SacchiHikaru commented 2 years ago

Before I get into the actual suggestions, the minor issue is that the two currently available options (single target and multi target combos) switch icons only if you put in the starter button for the combo, whereas as far as I can tell, every single other class does it with the end of the combo chain, even when the class only doesn't have branching combos (like DRK). Just a consistency thing.

Now for the actual suggestions:

TheGokki commented 2 years ago

I'm not sure Gallows into Gibbet is a good idea, they have positionals and it's hard to distinguish the two. By all means do it if there's a toggle to disable it, of course. Agree with Plentiful Harvest>Arcane Circle and Communio>Enshroud. Communio replacing Harpe makes sense too! I would then give the following suggestions:

The Enshroud combos are always the same. Remember that Void/Cross Reaping always alternate and can start with either, Grim Reaping instead of Void/Cross for AoE, Lemure's Scythe instead of Slice for AoE: Reaping > Reaping > Lemure's > Reaping > Reaping > Lemure's > Communio. Due to job mechanics this is ALWAYS the case. Lemure's abilities are oGCD and are weaved in-between Reaping abilities. Communio is ALWAYS used at the end. If Communio isn't available due to level sync, a fifth Reaping is used in its place.

steeben commented 2 years ago

Another suggestion; After using Hell's Ingress or Egress, both change to Regress.

attickdoor commented 2 years ago

i'll judge this for myself once i get reaper to 90.

Patchwerk commented 2 years ago

With the exception of Harpe into Communio all of SacchiHikaru's ideas pass the requirements listed in #119. That one in particular fails the requirement of actually saving button space, as there are plenty of scenarios where you would need to use Communio without having first used Harpe.

Gallows into Gibbet, or vice versa, can be a bit more complicated. There are contrived scenarios where you will want to start with one over the other due to fight positioning requirements. So individually these pass all of the requirements, though you would have to sometimes choose whether you want Gibbet or Gallows to take the starting spot on your action bar depending on the fight.

Overall great suggestions, I look forward to seeing at least some, or perhaps all, of these implemented once you get Reaper to 90 yourself!

Grammernatzi commented 2 years ago

Gallows into Gibbet, or vice versa, can be a bit more complicated. There are contrived scenarios where you will want to start with one over the other due to fight positioning requirements. So individually these pass all of the requirements, though you would have to sometimes choose whether you want Gibbet or Gallows to take the starting spot on your action bar depending on the fight.

A simple solution to this is to have Shadow of Death be replaced by Gallows when neither is enhanced and you have soul reaver. That way they can choose and two buttons are still saved. After that, there's no point to choosing as missing an enhanced positional does the same damage as a normal positional.

kaedys commented 2 years ago

I tend to land on not merging Gallows and Gibbet, simply due to the positionals aspect and the difficulty of figuring out which one to start on in any given situation. I feel like anything with a positional should be an intentional choice. I actually kinda dislike the Dragoon combo chain module in that respect, and wish I could remove Fang and Claw and Wheeling Thrust from the combo actions from this mod, simply because you need to actually be aware you're casting positionals.

It works fine for jobs like Samurai and Ninja, since the end ability of the chain is the only positional, so the button that holds each combo chain can be used to differentiate the positional. For example, if you have Aeolian Edge on one button and Armor Crush on another, with both set to execute their combo chain, which button you're hitting still differentiates which positional you're using. Same for Samurai, but not for Dragoon, since the two different positionals are executed in series by the same button hit repeatedly, requiring you to pay attention to the button icon itself so you know when you shift positions.

I fear the same issue would occur with Gallows and Gibbet, and all the worse because they have so similar icons. Unless you're looking at your tooltips or keep a very good memory, you'll have extreme difficulty telling which positional you're on.

So I guess it depends on how much this mod is intended to enable "good enough" type play. If someone doesn't care about the positionals and is ok with missing ~half of them (by, for example, just standing behind the boss the whole time), and just wants to reduce the Soul Reaver spender to a single button, it would be a useful option, I guess. But I'm not sure that's really what this mod is there for. Concealing decisions players do need to react to by changing their positions feels like a bad road to go down.

To be honest, I think this should become an additional rule in #119: combo suggestions never use attacks with different positional on the same button. Dragoon's combos can be grandfathered in, of course (though I'd love an option to disable just Wheeling Thrust and Fang and Claw from the combo chains). But I do not think this mod should be concealing positional attacks, merging different positionals into the same button, because the player has to know which they are using to avoid DPS loss.


As for the Enshroud versions, I don't care as much about those, since they lack positionals, so it doesn't matter in the slightest which one you start with and which one you're casting at the moment. Personally, I don't intend to use an option that merges them, should it be added, because I still want Gibbet and Gallows separated on my bars, so it's not saving bar space. In addition, because of the lack of positions and the fact that the 4 Enshroud GCDs occur back to back (rather than spaced out like Gibbet and Gallows), I find little difficulty in keeping track of which one I'm on. Merging them would, if anything, just help avoid the accidental double-press of one during rapid button clicking on the shortened GCD.

I also dislike the notion of replacing Soul Slice with Blood Stalk (and Soul Scythe with Grim Swathe), as there are valid reasons to use Soul Slice/Scythe even when at 50 gauge (for example, to get the first charge rolling upon entering a new trash pack, then going into Guillotine spam). The two buttons are not mutually exclusive, which fails the first of the 3 tests in #119.

A simple solution to this is to have Shadow of Death be replaced by Gallows when neither is enhanced and you have soul reaver.

This might be an option, but it struggles during Enshroud. You never want to cast Shadow of Death (or anything else) while you have Soul Reaver, as it drops the Soul Reaver effect. So that saves space there.

However, during Enshroud, you can still cast Shadow of Death without penalty, and there are conceivable situations where you'd want to (ex. you oopsied and the debuff dropped before or during Enshroud). That gets into complex decision territory, because you may want to refresh it, but you may also want to even before it's faded (if it has, for example, 3s left and you just went into Enshroud), but in other cases you wouldn't want to (boss goes immune/untargetable in <10s, just enough time to finish your Enshroud, but not if you reapply Shadow of Death first).

I'd say this still doesn't end up saving bar space, because Shadow of Death is not mutually exclusive with Cross Reaping and Void Reaping, even if it is with Gibbet and Gallows.


Realistically, the only ones I really would like to see are:

Grammernatzi commented 2 years ago

This might be an option, but it struggles during Enshroud. You never want to cast Shadow of Death (or anything else) while you have Soul Reaver, as it drops the Soul Reaver effect. So that saves space there.

However, during Enshroud, you can still cast Shadow of Death without penalty, and there are conceivable situations where you'd want to (ex. you oopsied and the debuff dropped before or during Enshroud).

A solution for this, as well, is to just have a one button combo for shroud, but make it two button outside of shroud (for starting the combo, or just in general for people who like having the option). I have already tested this myself and it seems to cause no issues. I even tested an option for someone who prefers to still have the buttons for gibbet and gallows separate, similar to you, and that works well while saving two buttons worth of space. It just simply becomes a one button combo when you are in shroud.

Also, your idea for dragoon's positionals is an interesting one, and I agree, partially. I don't think the current combo should be removed, but I think the fang and claw and Wheeling thrust additions should be a separate option. Or, perhaps, have both combos become the separate actions, that way you still save the same amount of buttons but you don't have the one button does two positionals problem. I will test both of these myself to see how they do.

ArcanaXVIII commented 2 years ago

Personally, i'm not a fan of merging Gallows and GIbbet. What I would suggest though is replacing the basic AOE combo with Guillotine while under Soul Reaver. It saves one keybind and you never want to hit your normal combo while Soul Reaver is up.

Nillinn commented 2 years ago

Enshroud into Communio is probably the best one. I second that so much. Seems like such a "must have". if we had that one tweak only, i'd be already be 100% satisfied with Reaper lol

kaedys commented 2 years ago

Personally, i'm not a fan of merging Gallows and GIbbet. What I would suggest though is replacing the basic AOE combo with Guillotine while under Soul Reaver. It saves one keybind and you never want to hit your normal combo while Soul Reaver is up.

Not a bad idea. Note that you'd also need to replace it while under Enshroud, though, for Grim Reaping.

attickdoor commented 2 years ago

To be honest, I think this should become an additional rule in #119: combo suggestions never use attacks with different positional on the same button.

I don't have a problem with it for DRG for a few reasons: 1) It's purely deterministic. CT combo goes one way, FT combo goes the other way. That never varies. 2) The usage is always immediately following. Unlike RPR, which only gets to do successive Gallows/Gibbet after using Gluttony, DRG always uses WT and F&C right after each other. 3) You don't realize this because you haven't stared into the game client, but some buffs that enable the usage of other abilities exist purely to cover up for the fact that the combo tracker is very shoddily implemented. If you miss a positonal on a move that's a part of a combo chain, you drop your combo (timer gets reset to 0 and "last move used" is cleared). Those who played in ARR may remember dropping their CT combo if they missed Disembowel's positional. That's why. This is also why MNK has "form" buffs - to ensure that they can always actually go through with their 1-2-3. DRG's 4th and 5th combo moves operate in the same way. Because CT is a positional and because 4 is also a positional, you get buffs to ensure that you're still able to complete your combo even if you miss the positional.

RPR, on the other hand, does not operate under this assumption. Gibbet and Gallows are special moves unlocked in a non-combo-chain way, so it doesn't really make conceptual sense to merge them onto one button.

kaedys commented 2 years ago

RPR, on the other hand, does not operate under this assumption. Gibbet and Gallows are special moves unlocked in a non-combo-chain way, so it doesn't really make conceptual sense to merge them onto one button.

Yep, I agree. Also, there's a lot more time between them than on DRG. Reaper can in some cases go close to 30s without using either one, if they're pooling Soul Gauge for some reason (ex. when I pool Shroud and then Soul near the end of the last trash pack before a boss, so I can do 3-4 Enshrouds within the first minute of the boss fight). Pretty easy to forget which one is buffed already. If they're just the same button, you don't even have the keybind differentiation to tell them apart. It's a high probability that the player will lose 12.5% damage on ~half of their Soul Reaver spenders as a result.

Now, I'm not necessarily opposed to that. For some players, the back-and-forth between the two and nailing the positionals is more than they want to handle, and hitting half of the positionals and getting all of the Enhanced Gibbet/Gallows benefit is better than none (presuming they would otherwise either just use one of the two exclusively, or the two essentially at random). However, it feels out of character with this mod, and also seems to distinctly cross the still-not-really-defined lines that the authors of Dalamud want to place around the capabilities of at least officially-indexed mods.

ArkfrostLumas commented 2 years ago

Agree on Arcane Circle > Plentiful Harvest.

Explanation so you don't have to remember:

So you always must use Arcane Circle first, and you can only use Plentiful Harvest within the next 35s at best, while Arcane Circle has 120s cooldown.

AnthonyScaglione commented 2 years ago

Among the suggestions that other people have said, I would really love: Arcane circle -> plentiful harvest Enshroud -> Communio

However, I also suggest this. Lots of people have been saying they want both ingress and egress to turn into regress, but I would much rather have ingress/egress (whichever one you pressed) to turn into harpe.

So when you press Ingress: Egress -> Regress Ingress -> Harpe

And opposite for pressing egress. These buttons each explicitly enable enhanced harpe and have no other functionality beyond that while they are on cooldown

Zerosystem86 commented 2 years ago

"I'm not sure Gallows into Gibbet is a good idea, they have positionals and it's hard to distinguish the two. " Honestly it doesnt matter regarding positional. Because most bosses are either omni-positional or you can bypass them by just "on use" True North".

kaedys commented 2 years ago

Positionals still matter. Of the existing savage fights, 3 of the 4 have positionals (only P2S lacks them), and 1 of the 2 extremes has them. True North can be used for 10 seconds out of every 45 seconds, on average (with a bonus charge at the start of the fight). Generally, if someone is feeling lazy about positionals, that's used with Gluttony every minute, giving one extra charge at the start and again every 4 minutes. Over the course of 2 minutes, Reaper use on average 10 Gibbet/Gallows, of which 4 are from Gluttony. Depending on timing, you might be able to get 1 additional one during the once-per-minute True North for Gluttony, so 4-6 of the 10 per 2 minutes. That still leaves 4-6 per 2 minutes unaccounted for. Simply wiffing on half of the positionals because the mod is hiding which one is which from you does not seem to be in the spirit of this mod.

Beyond which, it fails the most basic standards that attickdoor has put forth. The two are not mutually exclusive, not even remotely. You never want to cast one when the other is empowered, but the same is true of many buttons that this mod does not merge. It's also making more decision for you than, I would argue, any other combo currently present in the mod. As previous, I don't even think the mod should even be handling Wheeling Thrust and Fang and Claw the way it does. Personally, I prefer the version of that combo in Daemitus's fork, where the True Thrust button unconditionally becomes Fang and Claw and the Chaos Thrust button unconditionally becomes Wheeling Thrust (when you have either buff). So the rear positional is always on the rear button and the flank on the flank. So instead of doing 1, 1, 1, 1, 1, 2, 2, 2, 2, 2 for the 10-part Dragoon sequence, with the positional changing between the last two presses of both 1 and 2, you do 1, 1, 1, 1, 2, 2, 2, 2, 2, 1, and the button you hit enforces the positional. You always hit 1 to do a rear positional and always hit 2 to do a flank positional (though, of course, not all buttons on 1 and 2 have positionals, it's just that all of them that do have the same positional).

Basically, I stand by my prior statement. In my opinion, this mod should not be hiding positionals in the same button, especially if they are potentially back-to-back usages with differing positionals. Hiding Gibbet and Gallows behind the same would be, imo, a mistake.

The way that Daemitus's fork handles it could work here, though. He merges Gibbet and Gallows down into Slice (et al) and Soul Slice when you have Soul Reaper or Enshroud active. You physically can't use either the Slice combo or Soul Slice when you're Enshrouded, and you never want to when you have Grim Reaping stacks, so it saves bar space (you literally don't need to have Gibbet or Gallows on your bar at all). So, for example, I would hit my normal Slice combo, then hit Blood Stalk (or an unveiled variant on the same button), then hit Slice button again, which has now become Gallow. I hit Soul Slice to generate Soul again, then Blood Stalk (/unveiled), then hit the Soul Slice button again, which has now become Gibbet. My Slice always becomes Gallows (or the Enshroud equivalent), and my Soul Slice always becomes Gibbet (of course, there's an option to reverse which one goes to which button). It keeps the positionals consistent by button, I'm making the decision of which one to hit, but it still saves button space, and largely adheres to attickdoor's pre-requisites for a combo. Similar, Guillotine/Grim Reaping is merged into the AoE combo button.