search

atuttle / Taffy

:candy: The REST Web Service framework for ColdFusion and Lucee
http://taffy.io
Other
226 stars 118 forks source link

Use Taffy-branded logo #428

Open JamoCA opened 2 years ago

JamoCA commented 2 years ago

Use transparent PNG (using data URI) for favicon & H1 header on dashboard.

netlify[bot] commented 2 years ago

Deploy Preview for taffy-docs canceled.

Name Link
Latest commit c14b5e740641fe9bb19e650af9104fb4e1b20ec7
Latest deploy log https://app.netlify.com/sites/taffy-docs/deploys/62450c2a3f0e7a000882862b
atuttle commented 2 years ago

Rather than embed it as a data-image twice, why not create a file and link to that?

JamoCA commented 2 years ago

The data URIs are actually different. I used a smaller favicon generated by RealFavIconGenerator [https://realfavicongenerator.net/] and think I used an SVG for the logo.

I reviewed the main source and noticed that two (2) CSS files were included using cfinclude (rather than using a regular HTML link tag). I also noticed that the none of the CFM/CFC files used img tags. While there is a logo-lg.png file, it is only used for the readme.md file, isn't a square image and wasn't used anywhere else. I'm not sure why this was done, but thought it could be due to path issues and I didn't want to create any problems.

I can generate both static resource files if you'd prefer to use them instead. (I cropped the readme logo and submitted it to RealFaviconGenerator.)

atuttle commented 2 years ago

Yes, please. Let's use static files.