browser detection doesn't work in linux/firefox

audacity / audacity.github.io

source code of the Audacity website

https://www.audacityteam.org/

4 stars 6 forks source link

browser detection doesn't work in linux/firefox #20

Closed LWinterberg closed 8 months ago

LWinterberg commented 9 months ago

Broken UA string:

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0
Mozilla/5.0 (X11; Ubuntu; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.0 Safari/605.1.15

Working: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36

broken result is the default state (download links to /download, musehub to musehub.com)

LWinterberg commented 8 months ago

Looking at https://www.whatsmyua.info/ it seems like these libraries look at "X11; Ubuntu; Linux" and instead of inferring "oh yes this is one of the many linux variants" they instead go "this is 64 bit ubuntu and we don't know anything else about it". It feels like there should be a better way of doing this which still excludes android but maybe not? I just added some of the common linux cases instead ¯\_(ツ)_/¯