search

audipras / pe

0 stars 0 forks source link

Alias is case-sensitive when being used to create a tag #4

Open audipras opened 2 weeks ago

audipras commented 2 weeks ago

Although touched upon in the planned enhancements, it doesn't describe this issue, since it only says to enforce case-insensitivity for tags (not aliases) to promote consistency. The design explanation in the developer guide however makes it clear that you can't add both "v" and "V". However, you then expect to be able to create a tag with both "v" and "V", but you are unable to.

image.png

The addShortCut command is case sensitive when I'm trying to add new aliases (e.g. I can't add the alias "v" when I already have the alias "V"). However, when adding a tag using a command, the alias "V" will add the correct tag (e.g. Vegan), while the alias "v" will simply give the tag "v". The difference in case sensitivity here is inconsistent, unintuitive, and could also result in a lot of human error.

Steps to reproduce:

  1. Add an alias in lowercase to a tag.
  2. Attempt to edit a person with both upper and lower case aliases.

Expected: Both aliases should net the same net tag.

Actual: The lower case alias properly changes the tag (e.g. "v" maps to the tag "Vegan"). However, "V" just gives the tag "V", not "Vegan".

Screenshots:

After step 1:

image.png

Step 2: With upper case alias:

image.png

With lower case alias:

image.png

soc-pe-bot commented 1 week ago

Team's Response

Thank you for raising this issue.

We have assessed it as low severity, as users can already view the list of shortcut mappings using the listShortCut command before tagging with t/, which eliminates confusion during tagging. While we acknowledge the minor inconvenience caused, this concern is already addressed in our planned enhancement.

The planned enhancement clearly specifies that tags will become case-insensitive, ensuring consistency between shortcut handling and custom tagging. Specifically, as outlined in the planned enhancement: “We plan to make tags case-insensitive to promote consistency between shortcut handling and custom tagging.”

This change directly addresses the issue. For instance, if the shortcut "v" is set to "Vegan", the planned enhancement will ensure that tagging with t/ is case-insensitive. Just as how "t/Vegan" and "t/VEGAN" would be treated equally. As such, "t/V" and "t/v" would also be treated equally. This implies that using "v" or "V" would apply the shortcut.

Given that this issue is already addressed by the planned enhancement, we are rejecting this issue. Thank you for your feedback!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]