Testing against PHP 8.0

auraphp / Aura.SqlQuery

Independent query builders for MySQL, PostgreSQL, SQLite, and Microsoft SQL Server.

MIT License

450 stars 86 forks source link

Testing against PHP 8.0 #186

Closed AllenJB closed 2 years ago

AllenJB commented 3 years ago

This PR updates the 3.x branch with testing against PHP 8.0

Due to return type compatibility issues with the setUp() method, I could find no way to maintain compatibility with PHP versions older than 7.1 without duplicating the tests.

If you want me to duplicate the tests or have any alternative ideas on how to maintain compatibility with older PHP versions, please let me know.

AllenJB commented 3 years ago

Travis-CI seems to have failed to run on this PR, but I don't know why. Possibly an issue with travis-ci.org vs travis-ci.com?

I set up Travis on my fork for testing while I was working on these changes and tests passed there: https://travis-ci.com/github/AllenJB/Aura.SqlQuery/builds/230944424

harikt commented 2 years ago

Thank you for your work. Unfortunately we cannot drop support for 5.x in 3.x. So this has been fixed via https://github.com/auraphp/Aura.SqlQuery/pull/195 . We are using yoast polyfill now.